Skip to content

Commit

Permalink
net: Pass neighbours and dest address into NETEVENT_REDIRECT events.
Browse files Browse the repository at this point in the history
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Jul 5, 2012
1 parent fccd7d5 commit 1d248b1
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 15 deletions.
23 changes: 9 additions & 14 deletions drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ static const unsigned int MAX_ATIDS = 64 * 1024;
static const unsigned int ATID_BASE = 0x10000;

static void cxgb_neigh_update(struct neighbour *neigh);
static void cxgb_redirect(struct dst_entry *old, struct dst_entry *new);
static void cxgb_redirect(struct dst_entry *old, struct neighbour *old_neigh,
struct dst_entry *new, struct neighbour *new_neigh);

static inline int offload_activated(struct t3cdev *tdev)
{
Expand Down Expand Up @@ -968,8 +969,9 @@ static int nb_callback(struct notifier_block *self, unsigned long event,
}
case (NETEVENT_REDIRECT):{
struct netevent_redirect *nr = ctx;
cxgb_redirect(nr->old, nr->new);
cxgb_neigh_update(dst_get_neighbour_noref(nr->new));
cxgb_redirect(nr->old, nr->old_neigh,
nr->new, nr->new_neigh);
cxgb_neigh_update(nr->new_neigh);
break;
}
default:
Expand Down Expand Up @@ -1107,26 +1109,19 @@ static void set_l2t_ix(struct t3cdev *tdev, u32 tid, struct l2t_entry *e)
tdev->send(tdev, skb);
}

static void cxgb_redirect(struct dst_entry *old, struct dst_entry *new)
static void cxgb_redirect(struct dst_entry *old, struct neighbour *old_neigh,
struct dst_entry *new, struct neighbour *new_neigh)
{
struct net_device *olddev, *newdev;
struct neighbour *n;
struct tid_info *ti;
struct t3cdev *tdev;
u32 tid;
int update_tcb;
struct l2t_entry *e;
struct t3c_tid_entry *te;

n = dst_get_neighbour_noref(old);
if (!n)
return;
olddev = n->dev;

n = dst_get_neighbour_noref(new);
if (!n)
return;
newdev = n->dev;
olddev = old_neigh->dev;
newdev = new_neigh->dev;

if (!is_offloading(olddev))
return;
Expand Down
4 changes: 4 additions & 0 deletions include/net/netevent.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,14 @@
*/

struct dst_entry;
struct neighbour;

struct netevent_redirect {
struct dst_entry *old;
struct neighbour *old_neigh;
struct dst_entry *new;
struct neighbour *new_neigh;
const void *daddr;
};

enum netevent_notif_type {
Expand Down
7 changes: 6 additions & 1 deletion net/ipv6/route.c
Original file line number Diff line number Diff line change
Expand Up @@ -1687,6 +1687,7 @@ void rt6_redirect(const struct in6_addr *dest, const struct in6_addr *src,
struct rt6_info *rt, *nrt = NULL;
struct netevent_redirect netevent;
struct net *net = dev_net(neigh->dev);
struct neighbour *old_neigh;

rt = ip6_route_redirect(dest, src, saddr, neigh->dev);

Expand Down Expand Up @@ -1714,7 +1715,8 @@ void rt6_redirect(const struct in6_addr *dest, const struct in6_addr *src,
dst_confirm(&rt->dst);

/* Duplicate redirect: silently ignore. */
if (neigh == dst_get_neighbour_noref_raw(&rt->dst))
old_neigh = dst_get_neighbour_noref_raw(&rt->dst);
if (neigh == old_neigh)
goto out;

nrt = ip6_rt_copy(rt, dest);
Expand All @@ -1732,7 +1734,10 @@ void rt6_redirect(const struct in6_addr *dest, const struct in6_addr *src,
goto out;

netevent.old = &rt->dst;
netevent.old_neigh = old_neigh;
netevent.new = &nrt->dst;
netevent.new_neigh = neigh;
netevent.daddr = dest;
call_netevent_notifiers(NETEVENT_REDIRECT, &netevent);

if (rt->rt6i_flags & RTF_CACHE) {
Expand Down

0 comments on commit 1d248b1

Please sign in to comment.