Skip to content

Commit

Permalink
wl3501_cs: Remove unnecessary NULL check
Browse files Browse the repository at this point in the history
In wl3501_detach(), link->priv is checked for a NULL value before being
passed to free_netdev(). However, it cannot be NULL at this point as it
has already been passed to other functions, so just remove the check.

Addresses-Coverity: CID 710499: Null pointer dereferences (REVERSE_INULL)
Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200926174558.9436-1-alex.dewar90@gmail.com
  • Loading branch information
Alex Dewar authored and Kalle Valo committed Sep 29, 2020
1 parent 42af278 commit 1d2a853
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/net/wireless/wl3501_cs.c
Original file line number Diff line number Diff line change
Expand Up @@ -1433,9 +1433,7 @@ static void wl3501_detach(struct pcmcia_device *link)
wl3501_release(link);

unregister_netdev(dev);

if (link->priv)
free_netdev(link->priv);
free_netdev(dev);
}

static int wl3501_get_name(struct net_device *dev, struct iw_request_info *info,
Expand Down

0 comments on commit 1d2a853

Please sign in to comment.