Skip to content

Commit

Permalink
dmaengine: shdma: tidyup spin_unlock_bh on sh_chan_xfer_ld_queue
Browse files Browse the repository at this point in the history
It is not readable that there is any spin_unlock_bh on same function.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
  • Loading branch information
Kuninori Morimoto authored and Paul Mundt committed Jun 16, 2011
1 parent c4e0dd7 commit 1d2c098
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions drivers/dma/shdma.c
Original file line number Diff line number Diff line change
Expand Up @@ -766,10 +766,8 @@ static void sh_chan_xfer_ld_queue(struct sh_dmae_chan *sh_chan)

spin_lock_bh(&sh_chan->desc_lock);
/* DMA work check */
if (dmae_is_busy(sh_chan)) {
spin_unlock_bh(&sh_chan->desc_lock);
return;
}
if (dmae_is_busy(sh_chan))
goto sh_chan_xfer_ld_queue_end;

/* Find the first not transferred descriptor */
list_for_each_entry(desc, &sh_chan->ld_queue, node)
Expand All @@ -783,6 +781,7 @@ static void sh_chan_xfer_ld_queue(struct sh_dmae_chan *sh_chan)
break;
}

sh_chan_xfer_ld_queue_end:
spin_unlock_bh(&sh_chan->desc_lock);
}

Expand Down

0 comments on commit 1d2c098

Please sign in to comment.