Skip to content

Commit

Permalink
igb: Add double-check MTA_REGISTER for i210 and i211
Browse files Browse the repository at this point in the history
Add new function which checks MTA_REGISTER if its filled correctly.
If not then writes again to same register.
There is possibility that i210 and i211 could not accept
MTA_REGISTER settings, specially when you add and remove
many of multicast addresses in short time.
Without this patch there is possibility that multicast settings will be
not always set correctly in hardware.

Signed-off-by: Grzegorz Siwik <grzegorz.siwik@intel.com>
Tested-by: Dave Switzer <david.switzer@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
  • Loading branch information
Grzegorz Siwik authored and Tony Nguyen committed Apr 16, 2021
1 parent 26b67f5 commit 1d3cb90
Showing 1 changed file with 27 additions and 0 deletions.
27 changes: 27 additions & 0 deletions drivers/net/ethernet/intel/igb/e1000_mac.c
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,31 @@ static u32 igb_hash_mc_addr(struct e1000_hw *hw, u8 *mc_addr)
return hash_value;
}

/**
* igb_i21x_hw_doublecheck - double checks potential HW issue in i21X
* @hw: pointer to the HW structure
*
* Checks if multicast array is wrote correctly
* If not then rewrites again to register
**/
static void igb_i21x_hw_doublecheck(struct e1000_hw *hw)
{
bool is_failed;
int i;

do {
is_failed = false;
for (i = hw->mac.mta_reg_count - 1; i >= 0; i--) {
if (array_rd32(E1000_MTA, i) != hw->mac.mta_shadow[i]) {
is_failed = true;
array_wr32(E1000_MTA, i, hw->mac.mta_shadow[i]);
wrfl();
break;
}
}
} while (is_failed);
}

/**
* igb_update_mc_addr_list - Update Multicast addresses
* @hw: pointer to the HW structure
Expand Down Expand Up @@ -516,6 +541,8 @@ void igb_update_mc_addr_list(struct e1000_hw *hw,
for (i = hw->mac.mta_reg_count - 1; i >= 0; i--)
array_wr32(E1000_MTA, i, hw->mac.mta_shadow[i]);
wrfl();
if (hw->mac.type == e1000_i210 || hw->mac.type == e1000_i211)
igb_i21x_hw_doublecheck(hw);
}

/**
Expand Down

0 comments on commit 1d3cb90

Please sign in to comment.