Skip to content

Commit

Permalink
clocksource/drivers/time-armada-370-xp: Fix return value check
Browse files Browse the repository at this point in the history
The failure check of armada_370_xp_timer_setup() in
armada_370_xp_timer_common_init() is negated. This leads to an error message
and exit in case of a successful initialization.  Remove the stray '!'.

Fixes: 12549e2 ("clocksource/drivers/time-armada-370-xp: Convert init function to return error")
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: http://lkml.kernel.org/r/alpine.DEB.2.11.1607121731020.1344@hypnos.tec.linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Anna-Maria Gleixner authored and Thomas Gleixner committed Jul 12, 2016
1 parent 3d93f42 commit 1d661bf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/clocksource/time-armada-370-xp.c
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ static int __init armada_370_xp_timer_common_init(struct device_node *np)
}

res = armada_370_xp_timer_setup(this_cpu_ptr(armada_370_xp_evt));
if (!res) {
if (res) {
pr_err("Failed to setup timer");
return res;
}
Expand Down

0 comments on commit 1d661bf

Please sign in to comment.