Skip to content

Commit

Permalink
power: supply: rt9471: fix using wrong ce_gpio in rt9471_probe()
Browse files Browse the repository at this point in the history
Pass the correct 'ce_gpio' to IS_ERR(), and remove the ce_gpio in
chip data, make it all by SW control only, not to control by HW pin.

Fixes: 4a1a5f6 ("power: supply: rt9471: Add Richtek RT9471 charger driver")
Reviewed-by: ChiYuan Huang <cy_huang@richtek.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
  • Loading branch information
Yang Yingliang authored and Sebastian Reichel committed Feb 13, 2023
1 parent a915dfd commit 1d6cdc4
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/power/supply/rt9471.c
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ enum {

struct rt9471_chip {
struct device *dev;
struct gpio_desc *ce_gpio;
struct regmap *regmap;
struct regmap_field *rm_fields[F_MAX_FIELDS];
struct regmap_irq_chip_data *irq_chip_data;
Expand Down Expand Up @@ -851,7 +850,7 @@ static int rt9471_probe(struct i2c_client *i2c)

/* Default pull charge enable gpio to make 'CHG_EN' by SW control only */
ce_gpio = devm_gpiod_get_optional(dev, "charge-enable", GPIOD_OUT_HIGH);
if (IS_ERR(chip->ce_gpio))
if (IS_ERR(ce_gpio))
return dev_err_probe(dev, PTR_ERR(ce_gpio),
"Failed to config charge enable gpio\n");

Expand Down

0 comments on commit 1d6cdc4

Please sign in to comment.