Skip to content

Commit

Permalink
net: ravb: Start TX queues after HW initialization succeeded
Browse files Browse the repository at this point in the history
[ Upstream commit 6f32c08 ]

ravb_phy_start() may fail. If that happens, the TX queues will remain
started. Thus, move the netif_tx_start_all_queues() after PHY is
successfully initialized.

Fixes: c156633 ("Renesas Ethernet AVB driver proper")
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Claudiu Beznea authored and Greg Kroah-Hartman committed Dec 8, 2023
1 parent 87aaadb commit 1d91522
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/ethernet/renesas/ravb_main.c
Original file line number Diff line number Diff line change
@@ -1429,13 +1429,13 @@ static int ravb_open(struct net_device *ndev)
if (priv->chip_id == RCAR_GEN2)
ravb_ptp_init(ndev, priv->pdev);

netif_tx_start_all_queues(ndev);

/* PHY control start */
error = ravb_phy_start(ndev);
if (error)
goto out_ptp_stop;

netif_tx_start_all_queues(ndev);

return 0;

out_ptp_stop:

0 comments on commit 1d91522

Please sign in to comment.