Skip to content

Commit

Permalink
block: move timeout field in struct request to pack better
Browse files Browse the repository at this point in the history
After commit 64c7f1d, we went from 1 to 2 holes in my
test setup. If we move the timeout field a bit, we remove
both of those holes and shrink struct request by 8 bytes.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
  • Loading branch information
Jens Axboe committed Apr 5, 2017
1 parent 64c7f1d commit 1dd5198
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion include/linux/blkdev.h
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,8 @@ struct request {

unsigned short ioprio;

unsigned int timeout;

void *special; /* opaque pointer available for LLD use */

int errors;
Expand All @@ -223,7 +225,6 @@ struct request {

unsigned long deadline;
struct list_head timeout_list;
unsigned int timeout;

/*
* completion callback.
Expand Down

0 comments on commit 1dd5198

Please sign in to comment.