Skip to content

Commit

Permalink
cgroup, netclassid: remove double cond_resched
Browse files Browse the repository at this point in the history
commit 526f3d9 upstream.

Commit 018d26f ("cgroup, netclassid: periodically release file_lock
on classid") added a second cond_resched to write_classid indirectly by
update_classid_task. Remove the one in write_classid.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Dmitry Yakunin <zeil@yandex-team.ru>
Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Jiri Slaby authored and Greg Kroah-Hartman committed May 10, 2020
1 parent 2f83c2c commit 1e08af9
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions net/core/netclassid_cgroup.c
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,8 @@ static int write_classid(struct cgroup_subsys_state *css, struct cftype *cft,
cs->classid = (u32)value;

css_task_iter_start(css, 0, &it);
while ((p = css_task_iter_next(&it))) {
while ((p = css_task_iter_next(&it)))
update_classid_task(p, cs->classid);
cond_resched();
}
css_task_iter_end(&it);

return 0;
Expand Down

0 comments on commit 1e08af9

Please sign in to comment.