Skip to content

Commit

Permalink
drm/amd/display: display connected to dp-1 does not light up
Browse files Browse the repository at this point in the history
[why]
for vega, dp set_panel_mode is
handled by psp firmware. dal should not program the
register again.

[how]
dal does not program panel mode.

Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
Reviewed-by: Charlene Liu <Charlene.Liu@amd.com>
Acked-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
  • Loading branch information
Hersen Wu authored and Alex Deucher committed Aug 6, 2018
1 parent 81aca8e commit 1e1dbd6
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions drivers/gpu/drm/amd/display/dc/dc.h
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ struct dc_caps {
bool post_blend_color_processing;
bool force_dp_tps4_for_cp2520;
bool disable_dp_clk_share;
bool psp_setup_panel_mode;
};

struct dc_dcc_surface_param {
Expand Down
5 changes: 5 additions & 0 deletions drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,11 @@ static void setup_panel_mode(
enum dp_panel_mode panel_mode)
{
uint32_t value;
struct dc_context *ctx = enc110->base.ctx;

/* if psp set panel mode, dal should be program it */
if (ctx->dc->caps.psp_setup_panel_mode)
return;

ASSERT(REG(DP_DPHY_INTERNAL_CTRL));
value = REG_READ(DP_DPHY_INTERNAL_CTRL);
Expand Down
1 change: 1 addition & 0 deletions drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
Original file line number Diff line number Diff line change
Expand Up @@ -883,6 +883,7 @@ static bool construct(
dc->caps.i2c_speed_in_khz = 100;
dc->caps.max_cursor_size = 128;
dc->caps.dual_link_dvi = true;
dc->caps.psp_setup_panel_mode = true;

dc->debug = debug_defaults;

Expand Down

0 comments on commit 1e1dbd6

Please sign in to comment.