Skip to content

Commit

Permalink
perf symbols: Handle NULL dso in dso__name_len
Browse files Browse the repository at this point in the history
We should use "[unknown]" in this case, in concert with the code in
_hist_entry__dso_snprintf().

Otherwise we'll crash when recomputing the histogram column lengths in
hists__calc_col_len().

Signed-off-by: David S. Miller <davem@davemloft.net>
Link: http://lkml.kernel.org/r/20120325.162822.2267799792062571623.davem@davemloft.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
David Miller authored and Arnaldo Carvalho de Melo committed Mar 27, 2012
1 parent 3738d40 commit 1e2dd2f
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tools/perf/util/symbol.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ struct symbol_conf symbol_conf = {

int dso__name_len(const struct dso *dso)
{
if (!dso)
return strlen("[unknown]");
if (verbose)
return dso->long_name_len;

Expand Down

0 comments on commit 1e2dd2f

Please sign in to comment.