Skip to content

Commit

Permalink
HID: plantronics: remove superfluous .probe()
Browse files Browse the repository at this point in the history
Remove redundanct probe() callback, as it isn't doing anything extra
that HID core wouldn't do by default.

Reported-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Jiri Kosina committed Nov 3, 2014
1 parent 1a3f83f commit 1e48d54
Showing 1 changed file with 0 additions and 23 deletions.
23 changes: 0 additions & 23 deletions drivers/hid/hid-plantronics.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,28 +36,6 @@ static int plantronics_input_mapping(struct hid_device *hdev,
return -1;
}

static int plantronics_probe(struct hid_device *hdev,
const struct hid_device_id *id)
{
int ret;

ret = hid_parse(hdev);
if (ret) {
hid_err(hdev, "parse failed\n");
goto err;
}

ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT);
if (ret) {
hid_err(hdev, "hw start failed\n");
goto err;
}

return 0;
err:
return ret;
}

static const struct hid_device_id plantronics_devices[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_PLANTRONICS, HID_ANY_ID) },
{ }
Expand All @@ -68,7 +46,6 @@ static struct hid_driver plantronics_driver = {
.name = "plantronics",
.id_table = plantronics_devices,
.input_mapping = plantronics_input_mapping,
.probe = plantronics_probe,
};
module_hid_driver(plantronics_driver);

Expand Down

0 comments on commit 1e48d54

Please sign in to comment.