Skip to content

Commit

Permalink
xfs: fix log recovery erroring out on refcount recovery failure
Browse files Browse the repository at this point in the history
Per the comment in the error case of xfs_reflink_recover_cow, zero out
any error (after shutting down the log) so that we actually kill any new
intent items that might have gotten logged by later recovery steps.
Discovered by xfs/434, which few people actually seem to run.

Fixes: 2c1e31e ("xfs: place intent recovery under NOFS allocation context")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
  • Loading branch information
Darrick J. Wong authored and Chandan Babu R committed Feb 24, 2024
1 parent e6469b2 commit 1e5efd7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions fs/xfs/xfs_log_recover.c
Original file line number Diff line number Diff line change
Expand Up @@ -3532,6 +3532,7 @@ xlog_recover_finish(
* and AIL.
*/
xlog_force_shutdown(log, SHUTDOWN_LOG_IO_ERROR);
error = 0;
goto out_error;
}

Expand Down

0 comments on commit 1e5efd7

Please sign in to comment.