Skip to content

Commit

Permalink
LoongArch: Cleanup __builtin_constant_p() checking for cpu_has_*
Browse files Browse the repository at this point in the history
In the current configuration, cpu_has_lsx and cpu_has_lasx cannot be
constants. So cleanup the __builtin_constant_p() checking to reduce the
complexity.

Reviewed-by: WANG Xuerui <git@xen0n.name>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
  • Loading branch information
Huacai Chen committed Jul 28, 2023
1 parent 4eece7e commit 1e74ae3
Showing 1 changed file with 4 additions and 11 deletions.
15 changes: 4 additions & 11 deletions arch/loongarch/include/asm/fpu.h
Original file line number Diff line number Diff line change
Expand Up @@ -218,15 +218,8 @@ static inline void restore_lsx(struct task_struct *t)

static inline void init_lsx_upper(void)
{
/*
* Check cpu_has_lsx only if it's a constant. This will allow the
* compiler to optimise out code for CPUs without LSX without adding
* an extra redundant check for CPUs with LSX.
*/
if (__builtin_constant_p(cpu_has_lsx) && !cpu_has_lsx)
return;

_init_lsx_upper();
if (cpu_has_lsx)
_init_lsx_upper();
}

static inline void restore_lsx_upper(struct task_struct *t)
Expand Down Expand Up @@ -294,15 +287,15 @@ static inline void restore_lasx_upper(struct task_struct *t) {}

static inline int thread_lsx_context_live(void)
{
if (__builtin_constant_p(cpu_has_lsx) && !cpu_has_lsx)
if (!cpu_has_lsx)
return 0;

return test_thread_flag(TIF_LSX_CTX_LIVE);
}

static inline int thread_lasx_context_live(void)
{
if (__builtin_constant_p(cpu_has_lasx) && !cpu_has_lasx)
if (!cpu_has_lasx)
return 0;

return test_thread_flag(TIF_LASX_CTX_LIVE);
Expand Down

0 comments on commit 1e74ae3

Please sign in to comment.