Skip to content

Commit

Permalink
net: change init_inodecache() return void
Browse files Browse the repository at this point in the history
sock_init() call it but not check it's return value,
so change it to void return and add an internal BUG_ON() check.

Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
yuan linyu authored and David S. Miller committed Jan 9, 2017
1 parent 4289e60 commit 1e91163
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions net/socket.c
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ static void init_once(void *foo)
inode_init_once(&ei->vfs_inode);
}

static int init_inodecache(void)
static void init_inodecache(void)
{
sock_inode_cachep = kmem_cache_create("sock_inode_cache",
sizeof(struct socket_alloc),
Expand All @@ -296,9 +296,7 @@ static int init_inodecache(void)
SLAB_RECLAIM_ACCOUNT |
SLAB_MEM_SPREAD | SLAB_ACCOUNT),
init_once);
if (sock_inode_cachep == NULL)
return -ENOMEM;
return 0;
BUG_ON(sock_inode_cachep == NULL);
}

static const struct super_operations sockfs_ops = {
Expand Down

0 comments on commit 1e91163

Please sign in to comment.