Skip to content

Commit

Permalink
crypto: amcc - remove incorrect __init/__exit markups
Browse files Browse the repository at this point in the history
Even if bus is not hot-pluggable, the devices can be bound and unbound
from the driver via sysfs, so we should not be using __init/__exit
annotations on probe() and remove() methods. The only exception is
drivers registered with platform_driver_probe() which specifically
disables sysfs bind/unbind attributes.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Dmitry Torokhov authored and Herbert Xu committed Mar 11, 2015
1 parent 83ce01d commit 1eb8a1b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/crypto/amcc/crypto4xx_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1155,7 +1155,7 @@ struct crypto4xx_alg_common crypto4xx_alg[] = {
/**
* Module Initialization Routine
*/
static int __init crypto4xx_probe(struct platform_device *ofdev)
static int crypto4xx_probe(struct platform_device *ofdev)
{
int rc;
struct resource res;
Expand Down Expand Up @@ -1263,7 +1263,7 @@ static int __init crypto4xx_probe(struct platform_device *ofdev)
return rc;
}

static int __exit crypto4xx_remove(struct platform_device *ofdev)
static int crypto4xx_remove(struct platform_device *ofdev)
{
struct device *dev = &ofdev->dev;
struct crypto4xx_core_device *core_dev = dev_get_drvdata(dev);
Expand Down Expand Up @@ -1291,7 +1291,7 @@ static struct platform_driver crypto4xx_driver = {
.of_match_table = crypto4xx_match,
},
.probe = crypto4xx_probe,
.remove = __exit_p(crypto4xx_remove),
.remove = crypto4xx_remove,
};

module_platform_driver(crypto4xx_driver);
Expand Down

0 comments on commit 1eb8a1b

Please sign in to comment.