Skip to content

Commit

Permalink
[SCSI] libsas: Remove redundant phy state notification calls.
Browse files Browse the repository at this point in the history
In the case of an explicit sas_phy_enable call to disable a phy,
the LLDD provides the calls to sas_phy_disconnected and the
PHYE_LOSS_OF_SIGNAL event.

NOTE: This assumes that the lldd(s) generate the notification, which
appears to be the case, but only verfied on isci.

Signed-off-by: Jeff Skirvin <jeffrey.d.skirvin@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
  • Loading branch information
Jeff Skirvin authored and James Bottomley committed Feb 19, 2012
1 parent 2a559f4 commit 1f4fe89
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions drivers/scsi/libsas/sas_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -268,11 +268,8 @@ static int sas_phy_enable(struct sas_phy *phy, int enable)

if (enable)
ret = transport_sas_phy_reset(phy, 0);
else {
sas_phy_disconnected(asd_phy);
sas_ha->notify_phy_event(asd_phy, PHYE_LOSS_OF_SIGNAL);
else
ret = i->dft->lldd_control_phy(asd_phy, cmd, NULL);
}
} else {
struct sas_rphy *rphy = dev_to_rphy(phy->dev.parent);
struct domain_device *ddev = sas_find_dev_by_rphy(rphy);
Expand Down

0 comments on commit 1f4fe89

Please sign in to comment.