Skip to content

Commit

Permalink
dmaengine: Clarify cyclic transfer residue documentation
Browse files Browse the repository at this point in the history
The current documentation for the residue reported in a cyclic transfer
case mentions that the reported residue should be relative to the current
period only. However the definition of DMA_RESIDUE_GRANULARITY_SEGMENT
specifies that the residue should be updated after each period for
a cyclic transfer, which is in direct contradiction.

Moreover the pcm_dmaengine common code uses the residue relative to
the whole cyclic buffer size, not one period.

Correct the residue-related documentation to reflect this.

Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Link: https://lore.kernel.org/r/20220331134114.703782-1-paul.kocialkowski@bootlin.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
  • Loading branch information
Paul Kocialkowski authored and Vinod Koul committed Apr 11, 2022
1 parent ec834f1 commit 1f85453
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Documentation/driver-api/dmaengine/provider.rst
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ supported.
- Should use dma_set_residue to report it

- In the case of a cyclic transfer, it should only take into
account the current period.
account the total size of the cyclic buffer.

- Should return DMA_OUT_OF_ORDER if the device does not support in order
completion and is completing the operation out of order.
Expand Down

0 comments on commit 1f85453

Please sign in to comment.