Skip to content

Commit

Permalink
ALSA: oxygen: Delete an unnecessary check before the function call "s…
Browse files Browse the repository at this point in the history
…nd_pcm_suspend"

The snd_pcm_suspend() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Markus Elfring authored and Takashi Iwai committed Jan 4, 2015
1 parent a827977 commit 1fac168
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions sound/pci/oxygen/oxygen_lib.c
Original file line number Diff line number Diff line change
Expand Up @@ -736,8 +736,7 @@ static int oxygen_pci_suspend(struct device *dev)
snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);

for (i = 0; i < PCM_COUNT; ++i)
if (chip->streams[i])
snd_pcm_suspend(chip->streams[i]);
snd_pcm_suspend(chip->streams[i]);

if (chip->model.suspend)
chip->model.suspend(chip);
Expand Down

0 comments on commit 1fac168

Please sign in to comment.