Skip to content

Commit

Permalink
bnx2x: Fix static checker warning regarding `txdata_ptr'
Browse files Browse the repository at this point in the history
Incorrect checking of array instead of array contents in panic_dump
flow - results of commit e261199 ("bnx2x: Safe bnx2x_panic_dump()").

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Yuval Mintz authored and David S. Miller committed Aug 27, 2014
1 parent b0b46c7 commit 1fc3de9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -985,7 +985,7 @@ void bnx2x_panic_dump(struct bnx2x *bp, bool disable_int)
/* Tx */
for_each_cos_in_tx_queue(fp, cos)
{
if (!fp->txdata_ptr)
if (!fp->txdata_ptr[cos])
break;

txdata = *fp->txdata_ptr[cos];
Expand Down Expand Up @@ -1140,7 +1140,7 @@ void bnx2x_panic_dump(struct bnx2x *bp, bool disable_int)
for_each_cos_in_tx_queue(fp, cos) {
struct bnx2x_fp_txdata *txdata = fp->txdata_ptr[cos];

if (!fp->txdata_ptr)
if (!fp->txdata_ptr[cos])
break;

if (!txdata->tx_cons_sb)
Expand Down

0 comments on commit 1fc3de9

Please sign in to comment.