Skip to content

Commit

Permalink
PCI: rcar: Fix position of MSI enable bit
Browse files Browse the repository at this point in the history
The MSI enable is bit 31, not bit 28.  Set the correct bit to initialize
MSI.

Per Phil, "this is odd as MSI works before and after your patch. Since bit
31 just represents the value of MSICAP0[16].MSIE, I think this may just be
used for endpoints.  However, you are correct that the bit used was wrong."

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Phil Edworthy <phil.edworthy@renesas.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
  • Loading branch information
Nobuhiro Iwamatsu authored and Bjorn Helgaas committed Feb 24, 2015
1 parent c517d83 commit 1fc6aa9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/pci/host/pcie-rcar.c
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ static int rcar_pcie_hw_init(struct rcar_pcie *pcie)

/* Enable MSI */
if (IS_ENABLED(CONFIG_PCI_MSI))
rcar_pci_write_reg(pcie, 0x101f0000, PCIEMSITXR);
rcar_pci_write_reg(pcie, 0x801f0000, PCIEMSITXR);

/* Finish initialization - establish a PCI Express link */
rcar_pci_write_reg(pcie, CFINIT, PCIETCTLR);
Expand Down

0 comments on commit 1fc6aa9

Please sign in to comment.