Skip to content

Commit

Permalink
smsc: replace WARN_ON() with WARN_ON_SMP()
Browse files Browse the repository at this point in the history
spin_is_locked() always return false in uniprocessor configuration and therefore it
would be advise to repalce with WARN_ON_SMP().

Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Sanjeev Sharma authored and David S. Miller committed Aug 11, 2014
1 parent 2561cc1 commit 200d7db
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/smsc/smsc911x.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@

#ifdef CONFIG_DEBUG_SPINLOCK
#define SMSC_ASSERT_MAC_LOCK(pdata) \
WARN_ON(!spin_is_locked(&pdata->mac_lock))
WARN_ON_SMP(!spin_is_locked(&pdata->mac_lock))
#else
#define SMSC_ASSERT_MAC_LOCK(pdata) do {} while (0)
#endif /* CONFIG_DEBUG_SPINLOCK */
Expand Down

0 comments on commit 200d7db

Please sign in to comment.