Skip to content

Commit

Permalink
i2c: parport: start using pr_fmt
Browse files Browse the repository at this point in the history
Start using pr_fmt and convert all remaining printk to use
pr_* family of macros.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
[wsa: remove print on kzalloc failure]
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
  • Loading branch information
Sudip Mukherjee authored and Wolfram Sang committed Aug 10, 2015
1 parent c5f3d54 commit 2022611
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions drivers/i2c/busses/i2c-parport.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
GNU General Public License for more details.
* ------------------------------------------------------------------------ */

#define pr_fmt(fmt) "i2c-parport: " fmt

#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/init.h>
Expand Down Expand Up @@ -176,26 +178,24 @@ static void i2c_parport_attach(struct parport *port)
break;
}
if (i == MAX_DEVICE) {
pr_debug("i2c-parport: Not using parport%d.\n", port->number);
pr_debug("Not using parport%d.\n", port->number);
return;
}

adapter = kzalloc(sizeof(struct i2c_par), GFP_KERNEL);
if (adapter == NULL) {
printk(KERN_ERR "i2c-parport: Failed to kzalloc\n");
if (!adapter)
return;
}
memset(&i2c_parport_cb, 0, sizeof(i2c_parport_cb));
i2c_parport_cb.flags = PARPORT_FLAG_EXCL;
i2c_parport_cb.irq_func = i2c_parport_irq;
i2c_parport_cb.private = adapter;

pr_debug("i2c-parport: attaching to %s\n", port->name);
pr_debug("attaching to %s\n", port->name);
parport_disable_irq(port);
adapter->pdev = parport_register_dev_model(port, "i2c-parport",
&i2c_parport_cb, i);
if (!adapter->pdev) {
printk(KERN_ERR "i2c-parport: Unable to register with parport\n");
pr_err("Unable to register with parport\n");
goto err_free;
}

Expand Down Expand Up @@ -299,12 +299,12 @@ static struct parport_driver i2c_parport_driver = {
static int __init i2c_parport_init(void)
{
if (type < 0) {
printk(KERN_WARNING "i2c-parport: adapter type unspecified\n");
pr_warn("adapter type unspecified\n");
return -ENODEV;
}

if (type >= ARRAY_SIZE(adapter_parm)) {
printk(KERN_WARNING "i2c-parport: invalid type (%d)\n", type);
pr_warn("invalid type (%d)\n", type);
return -ENODEV;
}

Expand Down

0 comments on commit 2022611

Please sign in to comment.