Skip to content

Commit

Permalink
mmc: core: Make mmc_switch_status() available for mmc core
Browse files Browse the repository at this point in the history
Following changes needs mmc_switch_status() to be available both from mmc.c
and mmc_ops.c. Allow that by moving its implementation to mmc_ops.c and
make it available via mmc_ops.h.

Moving mmc_switch_status() to mmc_ops.c, also enables us to turn
mmc_switch_status_error() into static function. So let's take the
opportunity to change this as well.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
Tested-by: Jaehoon Chung <jh80.chung@samsung.com>
  • Loading branch information
Ulf Hansson committed Nov 29, 2016
1 parent 67e6db1 commit 20348d1
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 15 deletions.
13 changes: 0 additions & 13 deletions drivers/mmc/core/mmc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1003,19 +1003,6 @@ static int mmc_select_bus_width(struct mmc_card *card)
return err;
}

/* Caller must hold re-tuning */
static int mmc_switch_status(struct mmc_card *card)
{
u32 status;
int err;

err = mmc_send_status(card, &status);
if (err)
return err;

return mmc_switch_status_error(card->host, status);
}

/*
* Switch to the high-speed mode
*/
Expand Down
15 changes: 14 additions & 1 deletion drivers/mmc/core/mmc_ops.c
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ int mmc_spi_set_crc(struct mmc_host *host, int use_crc)
return err;
}

int mmc_switch_status_error(struct mmc_host *host, u32 status)
static int mmc_switch_status_error(struct mmc_host *host, u32 status)
{
if (mmc_host_is_spi(host)) {
if (status & R1_SPI_ILLEGAL_COMMAND)
Expand All @@ -455,6 +455,19 @@ int mmc_switch_status_error(struct mmc_host *host, u32 status)
return 0;
}

/* Caller must hold re-tuning */
int mmc_switch_status(struct mmc_card *card)
{
u32 status;
int err;

err = mmc_send_status(card, &status);
if (err)
return err;

return mmc_switch_status_error(card->host, status);
}

/**
* __mmc_switch - modify EXT_CSD register
* @card: the MMC card associated with the data transfer
Expand Down
2 changes: 1 addition & 1 deletion drivers/mmc/core/mmc_ops.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ int mmc_spi_set_crc(struct mmc_host *host, int use_crc);
int mmc_bus_test(struct mmc_card *card, u8 bus_width);
int mmc_send_hpi_cmd(struct mmc_card *card, u32 *status);
int mmc_can_ext_csd(struct mmc_card *card);
int mmc_switch_status_error(struct mmc_host *host, u32 status);
int mmc_switch_status(struct mmc_card *card);
int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
unsigned int timeout_ms, bool use_busy_signal, bool send_status,
bool ignore_crc);
Expand Down

0 comments on commit 20348d1

Please sign in to comment.