Skip to content

Commit

Permalink
net-next: mediatek: use mdiobus_free() in favour of kfree()
Browse files Browse the repository at this point in the history
The driver currently uses kfree() to clear the mii_bus. This is not the
correct way to clear the memory and mdiobus_free() should be used instead.
This patch fixes the two instances where this happens in the driver.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: John Crispin <john@phrozen.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
John Crispin authored and David S. Miller committed Jun 3, 2016
1 parent 8478b6c commit 207bdf1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/ethernet/mediatek/mtk_eth_soc.c
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ static int mtk_mdio_init(struct mtk_eth *eth)
return 0;

err_free_bus:
kfree(eth->mii_bus);
mdiobus_free(eth->mii_bus);

err_put_node:
of_node_put(mii_np);
Expand All @@ -295,7 +295,7 @@ static void mtk_mdio_cleanup(struct mtk_eth *eth)

mdiobus_unregister(eth->mii_bus);
of_node_put(eth->mii_bus->dev.of_node);
kfree(eth->mii_bus);
mdiobus_free(eth->mii_bus);
}

static inline void mtk_irq_disable(struct mtk_eth *eth, u32 mask)
Expand Down

0 comments on commit 207bdf1

Please sign in to comment.