Skip to content

Commit

Permalink
platform/x86: dell-wmi-sysman: Fix release_attributes_data() getting …
Browse files Browse the repository at this point in the history
…called twice on init_bios_attributes() failure

BugLink: https://bugs.launchpad.net/bugs/1931509

All calls of init_bios_attributes() will result in a
goto fail_create_group if they fail, which calls
release_attributes_data().

So there is no need to call release_attributes_data() from
init_bios_attributes() on failure itself.

Fixes: e8a60aa ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems")
Cc: Divya Bharathi <Divya_Bharathi@dell.com>
Cc: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210321115901.35072-5-hdegoede@redhat.com
(cherry picked from commit f4c4e9a)
Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com>
Signed-off-by: Timo Aaltonen <timo.aaltonen@canonical.com>
  • Loading branch information
Hans de Goede authored and Timo Aaltonen committed Jun 10, 2021
1 parent a1515f5 commit 2095239
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,6 @@ static int init_bios_attributes(int attr_type, const char *guid)

err_attr_init:
mutex_unlock(&wmi_priv.mutex);
release_attributes_data();
kfree(obj);
return retval;
}
Expand Down

0 comments on commit 2095239

Please sign in to comment.