Skip to content

Commit

Permalink
clk: clk-wm831x: fix a logic error
Browse files Browse the repository at this point in the history
Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function
wm831x_clkout_is_prepared() returns "true" when it fails to read
CLOCK_CONTROL_1. "true" means the device is already prepared. So
return "true" on the read failure seems improper.

Signed-off-by: Pan Bian <bianpan2016@163.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Fixes: f05259a ("clk: wm831x: Add initial WM831x clock driver")
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
  • Loading branch information
Pan Bian authored and Stephen Boyd committed Dec 8, 2016
1 parent 1221ae2 commit 2097920
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/clk/clk-wm831x.c
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ static int wm831x_clkout_is_prepared(struct clk_hw *hw)
if (ret < 0) {
dev_err(wm831x->dev, "Unable to read CLOCK_CONTROL_1: %d\n",
ret);
return true;
return false;
}

return (ret & WM831X_CLKOUT_ENA) != 0;
Expand Down

0 comments on commit 2097920

Please sign in to comment.