Skip to content

Commit

Permalink
media: davinci: vpif: fix unbalanced runtime PM enable
Browse files Browse the repository at this point in the history
commit d42b3ad upstream.

Make sure to disable runtime PM before returning on probe errors.

Fixes: 479f7a1 ("[media] davinci: vpif: adaptions for DT support")
Cc: stable@vger.kernel.org
Cc: Kevin Hilman <khilman@baylibre.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Johan Hovold authored and Greg Kroah-Hartman committed Apr 8, 2022
1 parent 7c9b915 commit 20f974d
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions drivers/media/platform/davinci/vpif.c
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,7 @@ static int vpif_probe(struct platform_device *pdev)
static struct resource *res, *res_irq;
struct platform_device *pdev_capture, *pdev_display;
struct device_node *endpoint = NULL;
int ret;

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
vpif_base = devm_ioremap_resource(&pdev->dev, res);
Expand Down Expand Up @@ -458,8 +459,8 @@ static int vpif_probe(struct platform_device *pdev)
res_irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
if (!res_irq) {
dev_warn(&pdev->dev, "Missing IRQ resource.\n");
pm_runtime_put(&pdev->dev);
return -EINVAL;
ret = -EINVAL;
goto err_put_rpm;
}

pdev_capture = devm_kzalloc(&pdev->dev, sizeof(*pdev_capture),
Expand Down Expand Up @@ -493,6 +494,12 @@ static int vpif_probe(struct platform_device *pdev)
}

return 0;

err_put_rpm:
pm_runtime_put(&pdev->dev);
pm_runtime_disable(&pdev->dev);

return ret;
}

static int vpif_remove(struct platform_device *pdev)
Expand Down

0 comments on commit 20f974d

Please sign in to comment.