Skip to content

Commit

Permalink
hwmon: (max6650) Drop call to thermal_cdev_update
Browse files Browse the repository at this point in the history
The call to thermal_cdev_update() causes any fan connected to the chip
to stop immediately. If the thermal subsystem is not set up to actually
handle the chip as cooling device, the remains stopped until is is
restarted manually with a write to a sysfs attribute.

There is evidence that thermal_cdev_update() should only be called from
thermal governors, not from thermal cooling device drivers. Drop the call.

Cc: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Tested-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
  • Loading branch information
Guenter Roeck committed Apr 23, 2019
1 parent f786dbb commit 212244f
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/hwmon/max6650.c
Original file line number Diff line number Diff line change
Expand Up @@ -801,8 +801,6 @@ static int max6650_probe(struct i2c_client *client,
dev_warn(&client->dev,
"thermal cooling device register failed: %ld\n",
PTR_ERR(data->cooling_dev));
else
thermal_cdev_update(data->cooling_dev);
#endif
return 0;
}
Expand Down

0 comments on commit 212244f

Please sign in to comment.