Skip to content

Commit

Permalink
net/mlx5e: Fix use after free in mlx5e_fs_init()
Browse files Browse the repository at this point in the history
Call mlx5e_fs_vlan_free(fs) before kvfree(fs).

Fixes: af8bbf7 ("net/mlx5e: Convert mlx5e_flow_steering member of mlx5e_priv to pointer")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
  • Loading branch information
Dan Carpenter authored and Saeed Mahameed committed Aug 22, 2022
1 parent 6514210 commit 21234e3
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/net/ethernet/mellanox/mlx5/core/en_fs.c
Original file line number Diff line number Diff line change
Expand Up @@ -1395,10 +1395,11 @@ struct mlx5e_flow_steering *mlx5e_fs_init(const struct mlx5e_profile *profile,
}

return fs;
err_free_fs:
kvfree(fs);

err_free_vlan:
mlx5e_fs_vlan_free(fs);
err_free_fs:
kvfree(fs);
err:
return NULL;
}
Expand Down

0 comments on commit 21234e3

Please sign in to comment.