Skip to content

Commit

Permalink
perf tools: Add missing headers, mostly stdlib.h
Browse files Browse the repository at this point in the history
Part of the erosion of util/util.h, that will lose its include stdlib.h,
we need to add it to places where it is needed but was getting it
indirectly.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-1imnqezw99ahc07fjeb51qby@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Arnaldo Carvalho de Melo committed Jul 9, 2019
1 parent fc50e0b commit 215a0d3
Show file tree
Hide file tree
Showing 26 changed files with 35 additions and 7 deletions.
1 change: 1 addition & 0 deletions tools/perf/arch/common.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// SPDX-License-Identifier: GPL-2.0
#include <stdio.h>
#include <stdlib.h>
#include "common.h"
#include "../util/env.h"
#include "../util/util.h"
Expand Down
2 changes: 2 additions & 0 deletions tools/perf/arch/powerpc/util/perf_regs.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
#include "../../util/perf_regs.h"
#include "../../util/debug.h"

#include <linux/kernel.h>

const struct sample_reg sample_reg_masks[] = {
SMPL_REG(r0, PERF_REG_POWERPC_R0),
SMPL_REG(r1, PERF_REG_POWERPC_R1),
Expand Down
1 change: 1 addition & 0 deletions tools/perf/arch/s390/util/header.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include <stdio.h>
#include <string.h>
#include <linux/ctype.h>
#include <linux/kernel.h>

#include "../../util/header.h"
#include "../../util/util.h"
Expand Down
1 change: 1 addition & 0 deletions tools/perf/builtin-config.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#include "util/debug.h"
#include "util/config.h"
#include <linux/string.h>
#include <stdlib.h>

static bool use_system_config, use_user_config;

Expand Down
1 change: 1 addition & 0 deletions tools/perf/builtin-help.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include <linux/kernel.h>
#include <errno.h>
#include <stdio.h>
#include <stdlib.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <unistd.h>
Expand Down
1 change: 1 addition & 0 deletions tools/perf/tests/llvm.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// SPDX-License-Identifier: GPL-2.0
#include <stdio.h>
#include <stdlib.h>
#include <bpf/libbpf.h>
#include <util/llvm-utils.h>
#include <util/cache.h>
Expand Down
1 change: 1 addition & 0 deletions tools/perf/tests/sample-parsing.c
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
#include <stdbool.h>
#include <inttypes.h>
#include <stdlib.h>
#include <linux/bitops.h>
#include <linux/kernel.h>
#include <linux/types.h>
Expand Down
1 change: 1 addition & 0 deletions tools/perf/tests/vmlinux-kallsyms.c
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include <linux/rbtree.h>
#include <inttypes.h>
#include <string.h>
#include <stdlib.h>
#include "map.h"
#include "symbol.h"
#include "util.h"
Expand Down
1 change: 1 addition & 0 deletions tools/perf/ui/browser.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#include <linux/types.h>
#include <stdarg.h>
#include <sys/types.h>

#define HE_COLORSET_TOP 50
#define HE_COLORSET_MEDIUM 51
Expand Down
1 change: 1 addition & 0 deletions tools/perf/ui/browsers/map.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#include <elf.h>
#include <inttypes.h>
#include <sys/ttydefaults.h>
#include <stdlib.h>
#include <string.h>
#include <linux/bitops.h>
#include "../../util/util.h"
Expand Down
1 change: 1 addition & 0 deletions tools/perf/ui/tui/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#include <errno.h>
#include <signal.h>
#include <stdbool.h>
#include <stdlib.h>
#include <linux/kernel.h>
#ifdef HAVE_BACKTRACE_SUPPORT
#include <execinfo.h>
Expand Down
2 changes: 1 addition & 1 deletion tools/perf/ui/tui/util.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
#include "../../util/util.h"
#include <signal.h>
#include <stdbool.h>
#include <string.h>
#include <stdlib.h>
#include <sys/ttydefaults.h>

#include "../../util/cache.h"
Expand Down
1 change: 1 addition & 0 deletions tools/perf/util/cputopo.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#include <sys/param.h>
#include <sys/utsname.h>
#include <inttypes.h>
#include <stdlib.h>
#include <api/fs/fs.h>

#include "cputopo.h"
Expand Down
1 change: 1 addition & 0 deletions tools/perf/util/db-export.c
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
*/

#include <errno.h>
#include <stdlib.h>

#include "evsel.h"
#include "machine.h"
Expand Down
1 change: 1 addition & 0 deletions tools/perf/util/debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include <string.h>
#include <stdarg.h>
#include <stdio.h>
#include <stdlib.h>
#include <sys/wait.h>
#include <api/debug.h>
#include <linux/time64.h>
Expand Down
3 changes: 2 additions & 1 deletion tools/perf/util/demangle-java.c
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
// SPDX-License-Identifier: GPL-2.0
#include <sys/types.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include "util.h"
#include "debug.h"
#include "symbol.h"

#include "demangle-java.h"

#include <linux/ctype.h>
#include <linux/kernel.h>

enum {
MODE_PREFIX = 0,
Expand Down
2 changes: 1 addition & 1 deletion tools/perf/util/dwarf-aux.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#include <errno.h>
#include <inttypes.h>
#include <stdbool.h>
#include "util.h"
#include <stdlib.h>
#include "debug.h"
#include "dwarf-aux.h"
#include "string2.h"
Expand Down
1 change: 1 addition & 0 deletions tools/perf/util/env.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include <errno.h>
#include <sys/utsname.h>
#include <bpf/libbpf.h>
#include <stdlib.h>

struct perf_env perf_env;

Expand Down
2 changes: 1 addition & 1 deletion tools/perf/util/parse-branch-options.c
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// SPDX-License-Identifier: GPL-2.0
#include "perf.h"
#include "util/util.h"
#include "util/debug.h"
#include <subcmd/parse-options.h>
#include "util/parse-branch-options.h"
#include <stdlib.h>

#define BRANCH_OPT(n, m) \
{ .name = n, .mode = (m) }
Expand Down
8 changes: 6 additions & 2 deletions tools/perf/util/parse-regs-options.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
// SPDX-License-Identifier: GPL-2.0
#include "perf.h"
#include "util/util.h"
#include <stdbool.h>
#include <stdlib.h>
#include <stdint.h>
#include <string.h>
#include <stdio.h>
#include "util/debug.h"
#include <subcmd/parse-options.h>
#include "util/perf_regs.h"
#include "util/parse-regs-options.h"

static int
Expand Down
1 change: 1 addition & 0 deletions tools/perf/util/strbuf.c
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include "util.h"
#include <linux/kernel.h>
#include <errno.h>
#include <stdlib.h>

/*
* Used as the default ->buf value, so that people can always assume
Expand Down
1 change: 1 addition & 0 deletions tools/perf/util/symbol-elf.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#include <fcntl.h>
#include <stdio.h>
#include <errno.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#include <inttypes.h>
Expand Down
1 change: 1 addition & 0 deletions tools/perf/util/symbol-minimal.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include <stdio.h>
#include <fcntl.h>
#include <string.h>
#include <stdlib.h>
#include <byteswap.h>
#include <sys/stat.h>

Expand Down
2 changes: 1 addition & 1 deletion tools/perf/util/target.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
#include "debug.h"

#include <pwd.h>
#include <stdlib.h>
#include <string.h>


enum target_errno target__validate(struct target *target)
{
enum target_errno ret = TARGET_ERRNO__SUCCESS;
Expand Down
1 change: 1 addition & 0 deletions tools/perf/util/thread-stack.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include <linux/list.h>
#include <linux/log2.h>
#include <errno.h>
#include <stdlib.h>
#include "thread.h"
#include "event.h"
#include "machine.h"
Expand Down
3 changes: 3 additions & 0 deletions tools/perf/util/usage.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
*/
#include "util.h"
#include "debug.h"
#include <stdio.h>
#include <stdlib.h>
#include <linux/compiler.h>

static __noreturn void usage_builtin(const char *err)
{
Expand Down

0 comments on commit 215a0d3

Please sign in to comment.