Skip to content

Commit

Permalink
[IA64] Fix possible race in destroy_and_reserve_irq()
Browse files Browse the repository at this point in the history
Currently, destroy_and_reserve_irq() sets irq_status[irq] UNUSED using
clear_irq_vector() and sets irq_status[irq] RSVD using reserve_irq().
But there is a race window because vector_lock is once released between
them. This patch fixes this race window.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
  • Loading branch information
Kenji Kaneshige authored and Tony Luck committed Jul 30, 2007
1 parent c4c376f commit 216fcd2
Showing 1 changed file with 6 additions and 11 deletions.
17 changes: 6 additions & 11 deletions arch/ia64/kernel/irq_ia64.c
Original file line number Diff line number Diff line change
Expand Up @@ -101,15 +101,6 @@ int check_irq_used(int irq)
return -1;
}

static void reserve_irq(unsigned int irq)
{
unsigned long flags;

spin_lock_irqsave(&vector_lock, flags);
irq_status[irq] = IRQ_RSVD;
spin_unlock_irqrestore(&vector_lock, flags);
}

static inline int find_unassigned_irq(void)
{
int irq;
Expand Down Expand Up @@ -302,10 +293,14 @@ static cpumask_t vector_allocation_domain(int cpu)

void destroy_and_reserve_irq(unsigned int irq)
{
unsigned long flags;

dynamic_irq_cleanup(irq);

clear_irq_vector(irq);
reserve_irq(irq);
spin_lock_irqsave(&vector_lock, flags);
__clear_irq_vector(irq);
irq_status[irq] = IRQ_RSVD;
spin_unlock_irqrestore(&vector_lock, flags);
}

static int __reassign_irq_vector(int irq, int cpu)
Expand Down

0 comments on commit 216fcd2

Please sign in to comment.