Skip to content

Commit

Permalink
batman-adv: Rename batadv_orig_node_vlan *_free_ref function to *_put
Browse files Browse the repository at this point in the history
The batman-adv source code is the only place in the kernel which uses the
*_free_ref naming scheme for the *_put functions. Changing it to *_put
makes it more consistent and makes it easier to understand the connection
to the *_get functions.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
  • Loading branch information
Sven Eckelmann authored and Antonio Quartulli committed Feb 23, 2016
1 parent 5fff282 commit 21754e2
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
8 changes: 4 additions & 4 deletions net/batman-adv/originator.c
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,11 @@ static void batadv_orig_node_vlan_release(struct kref *ref)
}

/**
* batadv_orig_node_vlan_free_ref - decrement the refcounter and possibly
* release the originator-vlan object
* batadv_orig_node_vlan_put - decrement the refcounter and possibly release
* the originator-vlan object
* @orig_vlan: the originator-vlan object to release
*/
void batadv_orig_node_vlan_free_ref(struct batadv_orig_node_vlan *orig_vlan)
void batadv_orig_node_vlan_put(struct batadv_orig_node_vlan *orig_vlan)
{
kref_put(&orig_vlan->refcount, batadv_orig_node_vlan_release);
}
Expand Down Expand Up @@ -917,7 +917,7 @@ struct batadv_orig_node *batadv_orig_node_new(struct batadv_priv *bat_priv,
* Immediately release vlan since it is not needed anymore in this
* context
*/
batadv_orig_node_vlan_free_ref(vlan);
batadv_orig_node_vlan_put(vlan);

for (i = 0; i < BATADV_FRAG_BUFFER_COUNT; i++) {
INIT_HLIST_HEAD(&orig_node->fragments[i].head);
Expand Down
2 changes: 1 addition & 1 deletion net/batman-adv/originator.h
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ batadv_orig_node_vlan_new(struct batadv_orig_node *orig_node,
struct batadv_orig_node_vlan *
batadv_orig_node_vlan_get(struct batadv_orig_node *orig_node,
unsigned short vid);
void batadv_orig_node_vlan_free_ref(struct batadv_orig_node_vlan *orig_vlan);
void batadv_orig_node_vlan_put(struct batadv_orig_node_vlan *orig_vlan);

/* hashfunction to choose an entry in a hash table of given size
* hash algorithm from http://en.wikipedia.org/wiki/Hash_table
Expand Down
10 changes: 5 additions & 5 deletions net/batman-adv/translation-table.c
Original file line number Diff line number Diff line change
Expand Up @@ -348,12 +348,12 @@ static void batadv_tt_global_size_mod(struct batadv_orig_node *orig_node,
spin_lock_bh(&orig_node->vlan_list_lock);
if (!hlist_unhashed(&vlan->list)) {
hlist_del_init_rcu(&vlan->list);
batadv_orig_node_vlan_free_ref(vlan);
batadv_orig_node_vlan_put(vlan);
}
spin_unlock_bh(&orig_node->vlan_list_lock);
}

batadv_orig_node_vlan_free_ref(vlan);
batadv_orig_node_vlan_put(vlan);
}

/**
Expand Down Expand Up @@ -1652,7 +1652,7 @@ batadv_tt_global_print_entry(struct batadv_priv *bat_priv,
((flags & BATADV_TT_CLIENT_ISOLA) ? 'I' : '.'),
((flags & BATADV_TT_CLIENT_TEMP) ? 'T' : '.'));

batadv_orig_node_vlan_free_ref(vlan);
batadv_orig_node_vlan_put(vlan);
}

print_list:
Expand Down Expand Up @@ -1684,7 +1684,7 @@ batadv_tt_global_print_entry(struct batadv_priv *bat_priv,
((flags & BATADV_TT_CLIENT_ISOLA) ? 'I' : '.'),
((flags & BATADV_TT_CLIENT_TEMP) ? 'T' : '.'));

batadv_orig_node_vlan_free_ref(vlan);
batadv_orig_node_vlan_put(vlan);
}
}

Expand Down Expand Up @@ -2503,7 +2503,7 @@ static bool batadv_tt_global_check_crc(struct batadv_orig_node *orig_node,
return false;

crc = vlan->tt.crc;
batadv_orig_node_vlan_free_ref(vlan);
batadv_orig_node_vlan_put(vlan);

if (crc != ntohl(tt_vlan_tmp->crc))
return false;
Expand Down

0 comments on commit 21754e2

Please sign in to comment.