Skip to content

Commit

Permalink
rds: Integer overflow in RDS cmsg handling
Browse files Browse the repository at this point in the history
In rds_cmsg_rdma_args(), the user-provided args->nr_local value is
restricted to less than UINT_MAX.  This seems to need a tighter upper
bound, since the calculation of total iov_size can overflow, resulting
in a small sock_kmalloc() allocation.  This would probably just result
in walking off the heap and crashing when calling rds_rdma_pages() with
a high count value.  If it somehow doesn't crash here, then memory
corruption could occur soon after.

Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dan Rosenberg authored and David S. Miller committed Nov 17, 2010
1 parent 7d98ffd commit 218854a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/rds/rdma.c
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ int rds_cmsg_rdma_args(struct rds_sock *rs, struct rds_message *rm,
goto out;
}

if (args->nr_local > (u64)UINT_MAX) {
if (args->nr_local > UIO_MAXIOV) {
ret = -EMSGSIZE;
goto out;
}
Expand Down

0 comments on commit 218854a

Please sign in to comment.