Skip to content

Commit

Permalink
x86/boot/compressed/64: Change add_identity_map() to take start and end
Browse files Browse the repository at this point in the history
Changing the function to take start and end as parameters instead of
start and size simplifies the callers which don't need to calculate the
size if they already have start and end.

Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lkml.kernel.org/r/20200907131613.12703-19-joro@8bytes.org
  • Loading branch information
Joerg Roedel authored and Borislav Petkov committed Sep 7, 2020
1 parent 8570978 commit 21cf237
Showing 1 changed file with 5 additions and 10 deletions.
15 changes: 5 additions & 10 deletions arch/x86/boot/compressed/ident_map_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,8 @@ static struct x86_mapping_info mapping_info;
/*
* Adds the specified range to the identity mappings.
*/
static void add_identity_map(unsigned long start, unsigned long size)
static void add_identity_map(unsigned long start, unsigned long end)
{
unsigned long end = start + size;

/* Align boundary to 2M. */
start = round_down(start, PMD_SIZE);
end = round_up(end, PMD_SIZE);
Expand All @@ -107,8 +105,6 @@ static void add_identity_map(unsigned long start, unsigned long size)
/* Locates and clears a region for a new top level page table. */
void initialize_identity_maps(void)
{
unsigned long start, size;

/* If running as an SEV guest, the encryption mask is required. */
set_sev_encryption_mask();

Expand Down Expand Up @@ -155,9 +151,7 @@ void initialize_identity_maps(void)
* New page-table is set up - map the kernel image and load it
* into cr3.
*/
start = (unsigned long)_head;
size = _end - _head;
add_identity_map(start, size);
add_identity_map((unsigned long)_head, (unsigned long)_end);
write_cr3(top_level_pgt);
}

Expand Down Expand Up @@ -189,7 +183,8 @@ static void do_pf_error(const char *msg, unsigned long error_code,

void do_boot_page_fault(struct pt_regs *regs, unsigned long error_code)
{
unsigned long address = native_read_cr2();
unsigned long address = native_read_cr2() & PMD_MASK;
unsigned long end = address + PMD_SIZE;

/*
* Check for unexpected error codes. Unexpected are:
Expand All @@ -204,5 +199,5 @@ void do_boot_page_fault(struct pt_regs *regs, unsigned long error_code)
* Error code is sane - now identity map the 2M region around
* the faulting address.
*/
add_identity_map(address & PMD_MASK, PMD_SIZE);
add_identity_map(address, end);
}

0 comments on commit 21cf237

Please sign in to comment.