Skip to content

Commit

Permalink
tools/virtio/ringtest: fix run-on-all.sh for offline cpus
Browse files Browse the repository at this point in the history
Since ef1b144 ("tools/virtio/ringtest: fix run-on-all.sh to work
without /dev/cpu") run-on-all.sh uses seq 0 $HOST_AFFINITY as the list
of ids of the CPUs to run the command on (assuming ids of online CPUs
are consecutive and start from 0), where $HOST_AFFINITY is the highest
CPU id in the system previously determined using lscpu.  This can fail
on systems with offline CPUs.

Instead let's use lscpu to determine the list of online CPUs.

Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
Fixes: ef1b144 ("tools/virtio/ringtest: fix run-on-all.sh to work without
/dev/cpu")
Reviewed-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
  • Loading branch information
Halil Pasic authored and Michael S. Tsirkin committed Jan 19, 2017
1 parent 8379cad commit 21f5eda
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions tools/virtio/ringtest/run-on-all.sh
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
#!/bin/sh

CPUS_ONLINE=$(lscpu --online -p=cpu|grep -v -e '#')
#use last CPU for host. Why not the first?
#many devices tend to use cpu0 by default so
#it tends to be busier
HOST_AFFINITY=$(lscpu -p=cpu | tail -1)
HOST_AFFINITY=$(echo "${CPUS_ONLINE}"|tail -n 1)

#run command on all cpus
for cpu in $(seq 0 $HOST_AFFINITY)
for cpu in $CPUS_ONLINE
do
#Don't run guest and host on same CPU
#It actually works ok if using signalling
Expand Down

0 comments on commit 21f5eda

Please sign in to comment.