Skip to content

Commit

Permalink
fsldma: do not cleanup descriptors in hardirq context
Browse files Browse the repository at this point in the history
"Cleaning" descriptors involves calling pending callbacks and clients
assume that their callback will only ever happen in softirq context.
Delay cleanup to the tasklet.

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Acked-by: Zhang Wei <wei.zhang@freescale.com>
  • Loading branch information
Dan Williams committed Mar 4, 2008
1 parent 173acc7 commit 222ccf9
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/dma/fsldma.c
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,6 @@ static irqreturn_t fsl_dma_chan_do_interrupt(int irq, void *data)
"nlndar 0x%016llx\n", (u64)get_cdar(fsl_chan),
(u64)get_ndar(fsl_chan));
stat &= ~FSL_DMA_SR_EOSI;
fsl_chan_ld_cleanup(fsl_chan);
}

/* If it current transfer is the end-of-transfer,
Expand Down

0 comments on commit 222ccf9

Please sign in to comment.