Skip to content

Commit

Permalink
drm/i915: implement timing override workarounds on LPT
Browse files Browse the repository at this point in the history
These workarounds are documented on the CRT mode set sequence.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Paulo Zanoni authored and Daniel Vetter committed Nov 11, 2012
1 parent 8a52fd9 commit 223a6fd
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions drivers/gpu/drm/i915/intel_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -1729,6 +1729,11 @@ static void lpt_enable_pch_transcoder(struct drm_i915_private *dev_priv,
assert_fdi_tx_enabled(dev_priv, cpu_transcoder);
assert_fdi_rx_enabled(dev_priv, TRANSCODER_A);

/* Workaround: set timing override bit. */
val = I915_READ(_TRANSA_CHICKEN2);
val |= TRANS_AUTOTRAIN_GEN_STALL_DIS;
I915_WRITE(_TRANSA_CHICKEN2, val);

val = TRANS_ENABLE;
pipeconf_val = I915_READ(PIPECONF(cpu_transcoder));

Expand Down Expand Up @@ -1780,6 +1785,11 @@ static void lpt_disable_pch_transcoder(struct drm_i915_private *dev_priv,
/* wait for PCH transcoder off, transcoder state */
if (wait_for((I915_READ(_TRANSACONF) & TRANS_STATE_ENABLE) == 0, 50))
DRM_ERROR("Failed to disable PCH transcoder\n");

/* Workaround: clear timing override bit. */
val = I915_READ(_TRANSA_CHICKEN2);
val &= ~TRANS_AUTOTRAIN_GEN_STALL_DIS;
I915_WRITE(_TRANSA_CHICKEN2, val);
}

/**
Expand Down

0 comments on commit 223a6fd

Please sign in to comment.