Skip to content

Commit

Permalink
net: stmmac: silence FPE kernel logs
Browse files Browse the repository at this point in the history
ethtool --show-mm can get real-time state of FPE.
fpe_irq_status logs should keep quiet.

tc-taprio can always query driver state, delete unbalanced logs.

Signed-off-by: Furong Xu <0x1207@gmail.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://patch.msgid.link/39943d7967f291674a97ef0572878aca273087e9.1725631883.git.0x1207@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Furong Xu authored and Jakub Kicinski committed Sep 10, 2024
1 parent 15d8a40 commit 22a805d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
8 changes: 4 additions & 4 deletions drivers/net/ethernet/stmicro/stmmac/dwmac5.c
Original file line number Diff line number Diff line change
Expand Up @@ -620,22 +620,22 @@ int dwmac5_fpe_irq_status(void __iomem *ioaddr, struct net_device *dev)

if (value & TRSP) {
status |= FPE_EVENT_TRSP;
netdev_info(dev, "FPE: Respond mPacket is transmitted\n");
netdev_dbg(dev, "FPE: Respond mPacket is transmitted\n");
}

if (value & TVER) {
status |= FPE_EVENT_TVER;
netdev_info(dev, "FPE: Verify mPacket is transmitted\n");
netdev_dbg(dev, "FPE: Verify mPacket is transmitted\n");
}

if (value & RRSP) {
status |= FPE_EVENT_RRSP;
netdev_info(dev, "FPE: Respond mPacket is received\n");
netdev_dbg(dev, "FPE: Respond mPacket is received\n");
}

if (value & RVER) {
status |= FPE_EVENT_RVER;
netdev_info(dev, "FPE: Verify mPacket is received\n");
netdev_dbg(dev, "FPE: Verify mPacket is received\n");
}

return status;
Expand Down
4 changes: 0 additions & 4 deletions drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1067,8 +1067,6 @@ static int tc_taprio_configure(struct stmmac_priv *priv,
if (ret)
goto disable;

netdev_info(priv->dev, "configured EST\n");

return 0;

disable:
Expand All @@ -1087,8 +1085,6 @@ static int tc_taprio_configure(struct stmmac_priv *priv,

stmmac_fpe_map_preemption_class(priv, priv->dev, extack, 0);

netdev_info(priv->dev, "disabled FPE\n");

return ret;
}

Expand Down

0 comments on commit 22a805d

Please sign in to comment.