Skip to content

Commit

Permalink
pm: cpupower: bindings: Improve disable c_state block
Browse files Browse the repository at this point in the history
This commit fixes a bad comment, removes an unneeded code block, and
catches a few more states that cpuidle_state_disable with the test
script. Part of the motivation for this commit was I kept forgetting to
use sudo.

Signed-off-by: "John B. Wyatt IV" <jwyatt@redhat.com>
Signed-off-by: "John B. Wyatt IV" <sageofredondo@gmail.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
  • Loading branch information
John B. Wyatt IV authored and Shuah Khan committed Oct 2, 2024
1 parent 08a26a1 commit 2314dca
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions tools/power/cpupower/bindings/python/test_raw_pylibcpupower.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,21 @@
print(f"cstate count error: return code: {cpu_cstates_count}")

"""
Disable cstate (will fail if the above is 0, ex: a virtual machine)
Disable cstate (will fail if the above returns is under 1, ex: a virtual machine)
"""
cstate_disabled = p.cpuidle_state_disable(0, 0, 1)
if cpu_cstates_count == 0:
print(f"CPU 0 has {cpu_cstates_count} c-states")
else:
print(f"cstate count error: return code: {cpu_cstates_count}")

match cstate_disabled:
case 0:
print(f"CPU state disabled")
case -1:
print(f"Idlestate not available")
case -2:
print(f"Disabling is not supported by the kernel")
case -3:
print(f"No write access to disable/enable C-states: try using sudo")
case _:
print(f"Not documented")
print(f"Not documented: {cstate_disabled}")


# Pointer example
Expand Down

0 comments on commit 2314dca

Please sign in to comment.