Skip to content

Commit

Permalink
drm: i915: Explicitly apply PWM config extracted from pwm_args
Browse files Browse the repository at this point in the history
Call pwm_apply_args() just after requesting the PWM device so that the
polarity and period are initialized according to the information
provided in pwm_args.

This is an intermediate state, and pwm_apply_args() should be dropped as
soon as the atomic PWM infrastructure is in place and the driver makes
use of it.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
  • Loading branch information
Boris Brezillon authored and Thierry Reding committed May 17, 2016
1 parent cfae56f commit 2347aa7
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions drivers/gpu/drm/i915/intel_panel.c
Original file line number Diff line number Diff line change
Expand Up @@ -1640,6 +1640,12 @@ static int pwm_setup_backlight(struct intel_connector *connector,
return -ENODEV;
}

/*
* FIXME: pwm_apply_args() should be removed when switching to
* the atomic PWM API.
*/
pwm_apply_args(panel->backlight.pwm);

retval = pwm_config(panel->backlight.pwm, CRC_PMIC_PWM_PERIOD_NS,
CRC_PMIC_PWM_PERIOD_NS);
if (retval < 0) {
Expand Down

0 comments on commit 2347aa7

Please sign in to comment.