Skip to content

Commit

Permalink
hwmon: (adt7470) Fix some style issues
Browse files Browse the repository at this point in the history
In preparation for the changes that follow fix up some existing style
issues.
Specifically:
- add blank line between variable declaration and code
- use strscpy instead of strlcpy
- remove unnecessary braces

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Link: https://lore.kernel.org/r/20210826024121.15665-2-chris.packham@alliedtelesis.co.nz
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
  • Loading branch information
Chris Packham authored and Guenter Roeck committed Aug 27, 2021
1 parent 25572c8 commit 23bd022
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/hwmon/adt7470.c
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ struct adt7470_data {
static inline int adt7470_read_word_data(struct i2c_client *client, u8 reg)
{
u16 foo;

foo = i2c_smbus_read_byte_data(client, reg);
foo |= ((u16)i2c_smbus_read_byte_data(client, reg + 1) << 8);
return foo;
Expand Down Expand Up @@ -1282,7 +1283,7 @@ static int adt7470_detect(struct i2c_client *client,
if (revision != ADT7470_REVISION)
return -ENODEV;

strlcpy(info->type, "adt7470", I2C_NAME_SIZE);
strscpy(info->type, "adt7470", I2C_NAME_SIZE);

return 0;
}
Expand Down Expand Up @@ -1331,9 +1332,8 @@ static int adt7470_probe(struct i2c_client *client)

data->auto_update = kthread_run(adt7470_update_thread, client, "%s",
dev_name(hwmon_dev));
if (IS_ERR(data->auto_update)) {
if (IS_ERR(data->auto_update))
return PTR_ERR(data->auto_update);
}

return 0;
}
Expand Down

0 comments on commit 23bd022

Please sign in to comment.