Skip to content

Commit

Permalink
scsi: aha152x: Use DECLARE_COMPLETION_ONSTACK for non-constant comple…
Browse files Browse the repository at this point in the history
…tion

The _ONSTACK variant should be used for on-stack completion, otherwise it
will break lockdep. See also commit 6e9a473 ("[PATCH] completions:
lockdep annotate on stack completions").

Signed-off-by: Zhongqiu Han <quic_zhonhan@quicinc.com>
Link: https://lore.kernel.org/r/20240705103614.3650637-1-quic_zhonhan@quicinc.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
  • Loading branch information
Zhongqiu Han authored and Martin K. Petersen committed Jul 11, 2024
1 parent 6ca9fed commit 23cef42
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/scsi/aha152x.c
Original file line number Diff line number Diff line change
Expand Up @@ -1072,7 +1072,7 @@ static int aha152x_abort(struct scsi_cmnd *SCpnt)
static int aha152x_device_reset(struct scsi_cmnd * SCpnt)
{
struct Scsi_Host *shpnt = SCpnt->device->host;
DECLARE_COMPLETION(done);
DECLARE_COMPLETION_ONSTACK(done);
int ret, issued, disconnected;
unsigned char old_cmd_len = SCpnt->cmd_len;
unsigned long flags;
Expand Down

0 comments on commit 23cef42

Please sign in to comment.