Skip to content

Commit

Permalink
ALSA: asihpi: don't pass GFP_DMA32 to dma_alloc_coherent
Browse files Browse the repository at this point in the history
The DMA API does its own zone decisions based on the coherent_dma_mask.

[ Note: as the driver doesn't set the DMA coherent mask, we can assume
  the default 32bit DMA, hence it should be safe to drop the flag here
  -- tiwai ]

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Christoph Hellwig authored and Takashi Iwai committed Oct 14, 2018
1 parent 68da4fa commit 23fdf22
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/pci/asihpi/hpios.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ u16 hpios_locked_mem_alloc(struct consistent_dma_area *p_mem_area, u32 size,
/*?? any benefit in using managed dmam_alloc_coherent? */
p_mem_area->vaddr =
dma_alloc_coherent(&pdev->dev, size, &p_mem_area->dma_handle,
GFP_DMA32 | GFP_KERNEL);
GFP_KERNEL);

if (p_mem_area->vaddr) {
HPI_DEBUG_LOG(DEBUG, "allocated %d bytes, dma 0x%x vma %p\n",
Expand Down

0 comments on commit 23fdf22

Please sign in to comment.