Skip to content

Commit

Permalink
phy/rockchip: Use of_device_get_match_data()
Browse files Browse the repository at this point in the history
Use of_device_get_match_data() to simplify the code.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
Link: https://lore.kernel.org/r/20220304011755.2061529-1-chi.minghao@zte.com.cn
Signed-off-by: Vinod Koul <vkoul@kernel.org>
  • Loading branch information
Minghao Chi (CGEL ZTE) authored and Vinod Koul committed Apr 13, 2022
1 parent 3eb836d commit 2404387
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/phy/rockchip/phy-rockchip-typec.c
Original file line number Diff line number Diff line change
Expand Up @@ -1105,15 +1105,14 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev)
struct phy_provider *phy_provider;
struct resource *res;
const struct rockchip_usb3phy_port_cfg *phy_cfgs;
const struct of_device_id *match;
int index, ret;

tcphy = devm_kzalloc(dev, sizeof(*tcphy), GFP_KERNEL);
if (!tcphy)
return -ENOMEM;

match = of_match_device(dev->driver->of_match_table, dev);
if (!match || !match->data) {
phy_cfgs = of_device_get_match_data(dev);
if (!phy_cfgs) {
dev_err(dev, "phy configs are not assigned!\n");
return -EINVAL;
}
Expand All @@ -1123,7 +1122,6 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev)
if (IS_ERR(tcphy->base))
return PTR_ERR(tcphy->base);

phy_cfgs = match->data;
/* find out a proper config which can be matched with dt. */
index = 0;
while (phy_cfgs[index].reg) {
Expand Down

0 comments on commit 2404387

Please sign in to comment.