Skip to content

Commit

Permalink
cxl: Reduce scope for the variable “mm” in cxllib_get_PE_attributes()
Browse files Browse the repository at this point in the history
A local variable was used only within an if branch.
Thus move the definition for the variable “mm” into the corresponding
code block.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/5cee2b25-71e0-15aa-fba6-12211b8308aa@web.de
  • Loading branch information
Markus Elfring authored and Michael Ellerman committed Jan 31, 2021
1 parent b5952f8 commit 245a389
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/misc/cxl/cxllib.c
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,6 @@ int cxllib_get_PE_attributes(struct task_struct *task,
unsigned long translation_mode,
struct cxllib_pe_attributes *attr)
{
struct mm_struct *mm = NULL;

if (translation_mode != CXL_TRANSLATED_MODE &&
translation_mode != CXL_REAL_MODE)
return -EINVAL;
Expand All @@ -182,7 +180,7 @@ int cxllib_get_PE_attributes(struct task_struct *task,
true);
attr->lpid = mfspr(SPRN_LPID);
if (task) {
mm = get_task_mm(task);
struct mm_struct *mm = get_task_mm(task);
if (mm == NULL)
return -EINVAL;
/*
Expand Down

0 comments on commit 245a389

Please sign in to comment.