Skip to content

Commit

Permalink
drm/i915/gt: Tweak flushes around ivb ppgtt
Browse files Browse the repository at this point in the history
A small tweak to flush then invalidate appears to improve the
reliability of ppGTT switches on Ivybridge -- but does not improve
hsw/vlv bcs reliability.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Acked-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191231120857.4014900-1-chris@chris-wilson.co.uk
  • Loading branch information
Chris Wilson committed Dec 31, 2019
1 parent 2b64e61 commit 24c6627
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/gpu/drm/i915/gt/intel_ring_submission.c
Original file line number Diff line number Diff line change
Expand Up @@ -1394,7 +1394,7 @@ static int load_pd_dir(struct i915_request *rq,

intel_ring_advance(rq, cs);

return 0;
return rq->engine->emit_flush(rq, EMIT_FLUSH);
}

static inline int mi_set_context(struct i915_request *rq, u32 flags)
Expand Down Expand Up @@ -1584,7 +1584,7 @@ static int switch_mm(struct i915_request *rq, struct i915_address_space *vm)
if (ret)
return ret;

return rq->engine->emit_flush(rq, EMIT_FLUSH);
return rq->engine->emit_flush(rq, EMIT_INVALIDATE);
}

static int switch_context(struct i915_request *rq)
Expand Down

0 comments on commit 24c6627

Please sign in to comment.