Skip to content

Commit

Permalink
i2c: rcar: make sure irq is not threaded on Gen2 and earlier
Browse files Browse the repository at this point in the history
Ensure this irq runs as fast as possible.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
  • Loading branch information
Wolfram Sang authored and Wolfram Sang committed Jan 5, 2021
1 parent 25c2e0f commit 24c6d4b
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/i2c/busses/i2c-rcar.c
Original file line number Diff line number Diff line change
Expand Up @@ -928,6 +928,7 @@ static int rcar_i2c_probe(struct platform_device *pdev)
struct rcar_i2c_priv *priv;
struct i2c_adapter *adap;
struct device *dev = &pdev->dev;
unsigned long irqflags = 0;
int ret;

/* Otherwise logic will break because some bytes must always use PIO */
Expand Down Expand Up @@ -976,6 +977,9 @@ static int rcar_i2c_probe(struct platform_device *pdev)

rcar_i2c_write(priv, ICSAR, 0); /* Gen2: must be 0 if not using slave */

if (priv->devtype < I2C_RCAR_GEN3)
irqflags |= IRQF_NO_THREAD;

if (priv->devtype == I2C_RCAR_GEN3) {
priv->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (!IS_ERR(priv->rstc)) {
Expand All @@ -995,7 +999,7 @@ static int rcar_i2c_probe(struct platform_device *pdev)
priv->flags |= ID_P_HOST_NOTIFY;

priv->irq = platform_get_irq(pdev, 0);
ret = devm_request_irq(dev, priv->irq, rcar_i2c_irq, 0, dev_name(dev), priv);
ret = devm_request_irq(dev, priv->irq, rcar_i2c_irq, irqflags, dev_name(dev), priv);
if (ret < 0) {
dev_err(dev, "cannot get irq %d\n", priv->irq);
goto out_pm_disable;
Expand Down

0 comments on commit 24c6d4b

Please sign in to comment.