Skip to content

Commit

Permalink
perf stat: Move perf_evlist__(alloc|free|reset)_stats into stat object
Browse files Browse the repository at this point in the history
Moving perf_evlist__(alloc|free|reset)_stats into stat object,
so it could be used in following patches.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1435310967-14570-12-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Jiri Olsa authored and Arnaldo Carvalho de Melo committed Jun 26, 2015
1 parent a939512 commit 24e34f6
Show file tree
Hide file tree
Showing 4 changed files with 50 additions and 43 deletions.
42 changes: 0 additions & 42 deletions tools/perf/builtin-stat.c
Original file line number Diff line number Diff line change
Expand Up @@ -141,48 +141,6 @@ static inline void diff_timespec(struct timespec *r, struct timespec *a,
}
}

static void perf_evlist__free_stats(struct perf_evlist *evlist)
{
struct perf_evsel *evsel;

evlist__for_each(evlist, evsel) {
perf_evsel__free_stat_priv(evsel);
perf_evsel__free_counts(evsel);
perf_evsel__free_prev_raw_counts(evsel);
}
}

static int perf_evlist__alloc_stats(struct perf_evlist *evlist, bool alloc_raw)
{
struct perf_evsel *evsel;
int nthreads = thread_map__nr(evsel_list->threads);

evlist__for_each(evlist, evsel) {
int ncpus = perf_evsel__nr_cpus(evsel);

if (perf_evsel__alloc_stat_priv(evsel) < 0 ||
perf_evsel__alloc_counts(evsel, ncpus, nthreads) < 0 ||
(alloc_raw && perf_evsel__alloc_prev_raw_counts(evsel, ncpus, nthreads) < 0))
goto out_free;
}

return 0;

out_free:
perf_evlist__free_stats(evlist);
return -1;
}

static void perf_evlist__reset_stats(struct perf_evlist *evlist)
{
struct perf_evsel *evsel;

evlist__for_each(evlist, evsel) {
perf_evsel__reset_stat_priv(evsel);
perf_evsel__reset_counts(evsel);
}
}

static void perf_stat__reset_stats(void)
{
perf_evlist__reset_stats(evsel_list);
Expand Down
1 change: 0 additions & 1 deletion tools/perf/util/evlist.h
Original file line number Diff line number Diff line change
Expand Up @@ -289,5 +289,4 @@ void perf_evlist__to_front(struct perf_evlist *evlist,

void perf_evlist__set_tracking_event(struct perf_evlist *evlist,
struct perf_evsel *tracking_evsel);

#endif /* __PERF_EVLIST_H */
44 changes: 44 additions & 0 deletions tools/perf/util/stat.c
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#include <math.h>
#include "stat.h"
#include "evlist.h"
#include "evsel.h"
#include "thread_map.h"

void update_stats(struct stats *stats, u64 val)
{
Expand Down Expand Up @@ -186,3 +188,45 @@ void perf_evsel__free_prev_raw_counts(struct perf_evsel *evsel)
perf_counts__delete(evsel->prev_raw_counts);
evsel->prev_raw_counts = NULL;
}

int perf_evlist__alloc_stats(struct perf_evlist *evlist, bool alloc_raw)
{
struct perf_evsel *evsel;
int nthreads = thread_map__nr(evlist->threads);

evlist__for_each(evlist, evsel) {
int ncpus = perf_evsel__nr_cpus(evsel);

if (perf_evsel__alloc_stat_priv(evsel) < 0 ||
perf_evsel__alloc_counts(evsel, ncpus, nthreads) < 0 ||
(alloc_raw && perf_evsel__alloc_prev_raw_counts(evsel, ncpus, nthreads) < 0))
goto out_free;
}

return 0;

out_free:
perf_evlist__free_stats(evlist);
return -1;
}

void perf_evlist__free_stats(struct perf_evlist *evlist)
{
struct perf_evsel *evsel;

evlist__for_each(evlist, evsel) {
perf_evsel__free_stat_priv(evsel);
perf_evsel__free_counts(evsel);
perf_evsel__free_prev_raw_counts(evsel);
}
}

void perf_evlist__reset_stats(struct perf_evlist *evlist)
{
struct perf_evsel *evsel;

evlist__for_each(evlist, evsel) {
perf_evsel__reset_stat_priv(evsel);
perf_evsel__reset_counts(evsel);
}
}
6 changes: 6 additions & 0 deletions tools/perf/util/stat.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ static inline void init_stats(struct stats *stats)
}

struct perf_evsel;
struct perf_evlist;

bool __perf_evsel_stat__is(struct perf_evsel *evsel,
enum perf_stat_evsel_id id);

Expand Down Expand Up @@ -100,4 +102,8 @@ void perf_evsel__free_stat_priv(struct perf_evsel *evsel);
int perf_evsel__alloc_prev_raw_counts(struct perf_evsel *evsel,
int ncpus, int nthreads);
void perf_evsel__free_prev_raw_counts(struct perf_evsel *evsel);

int perf_evlist__alloc_stats(struct perf_evlist *evlist, bool alloc_raw);
void perf_evlist__free_stats(struct perf_evlist *evlist);
void perf_evlist__reset_stats(struct perf_evlist *evlist);
#endif

0 comments on commit 24e34f6

Please sign in to comment.