Skip to content

Commit

Permalink
tty: use 'if' in send_break() instead of 'goto'
Browse files Browse the repository at this point in the history
Now, the "jumped-over" code is simple enough to be put inside an 'if'.
Do so to make it 'goto'-less.

Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20230919085156.1578-16-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Jiri Slaby (SUSE) authored and Greg Kroah-Hartman committed Oct 3, 2023
1 parent fd99392 commit 24f2cd0
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions drivers/tty/tty_io.c
Original file line number Diff line number Diff line change
Expand Up @@ -2482,11 +2482,10 @@ static int send_break(struct tty_struct *tty, unsigned int duration)
return -EINTR;

retval = tty->ops->break_ctl(tty, -1);
if (retval)
goto out;
msleep_interruptible(duration);
retval = tty->ops->break_ctl(tty, 0);
out:
if (!retval) {
msleep_interruptible(duration);
retval = tty->ops->break_ctl(tty, 0);
}
tty_write_unlock(tty);

if (signal_pending(current))
Expand Down

0 comments on commit 24f2cd0

Please sign in to comment.